• 0 Posts
  • 19 Comments
Joined 1 year ago
cake
Cake day: June 16th, 2023

help-circle







  • It’s not just random, it simply does not even work. Because they set this:

    +/*Preferred Core featue is supported*/
    +static bool prefcore = true;
    

    And later in the code they do the if condition wrong:

    +	if (prefcore)
    +		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
    +	else
    +		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
    

    if should look like this:

    +	if (prefcore)
    +		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
    +	else
    +		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
    

    There is probably even more wrong, looking at the code quality, but this at least makes the preferred core work.











  • but I have used the video encode hardware on AMD cards via VAAPI and it was competent and much faster than x264/x265 on the CPU.

    Yes, it’s faster than the CPU, which is no surprise, but the quality is incredibly worse than NVENC. I switched to AMD earlier this year and I knew that the AMD video encoder wouldn’t match NVENC, but the difference is much bigger than I’ve ever thought.